Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Incorrect "latest" version leads to missing "Deprecated" message. #48783

Open
lgarron opened this issue Oct 5, 2021 · 2 comments
Open

Comments

@lgarron
Copy link

@lgarron lgarron commented Oct 5, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/github/fakeca

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.71 Safari/537.36

Screenshot

Screen Shot 2021-10-04 at 17 07 37

What did you do?

I published a v0.2.0 tag for three packages, each with a similar // Deprecated: comment in go.mod:

What did you expect to see?

All three show a ⚠ Deprecated message like this:

Screen Shot 2021-10-04 at 17 09 01

What did you see instead?

https://pkg.go.dev/github.com/github/fakeca doesn't show the message, but the other packages do.


https://pkg.go.dev/github.com/github/fakeca?tab=versions seems to know about v0.2.0 but it doesn't seem to be getting picked up as the "latest". https://pkg.go.dev/github.com/github/fakeca@v0.2.0 shows this, and clicking "Go to latest" takes you to v0.1.0:

Screen Shot 2021-10-04 at 17 14 01

@gopherbot gopherbot added this to the Unreleased milestone Oct 5, 2021
@lgarron lgarron changed the title x/pkgsite: x/pkgsite: Incorrect "latest" version leads to missing "Deprecated" message. Oct 5, 2021
@FiloSottile
Copy link
Contributor

@FiloSottile FiloSottile commented Oct 5, 2021

The proxy has the right latest, so pkgsite seems to be behind.

go mod download -json github.com/github/fakeca@latest
{
	"Path": "github.com/github/fakeca",
	"Version": "v0.2.0",
	"Info": "/Users/filippo/pkg/mod/cache/download/github.com/github/fakeca/@v/v0.2.0.info",
	"GoMod": "/Users/filippo/pkg/mod/cache/download/github.com/github/fakeca/@v/v0.2.0.mod",
	"Zip": "/Users/filippo/pkg/mod/cache/download/github.com/github/fakeca/@v/v0.2.0.zip",
	"Dir": "/Users/filippo/pkg/mod/github.com/github/fakeca@v0.2.0",
	"Sum": "h1:xtBwXN7dmDPK8U5z0KHW1jupDVTDSINxrKRAc5//XFY=",
	"GoModSum": "h1:XhVUBgZ9+o0O6XzVXOl4H5qNxkV/MImtB3FuI/Zcti0="
}

@jamalc jamalc removed this from the Unreleased milestone Oct 5, 2021
@jamalc jamalc added this to the pkgsite/unplanned milestone Oct 5, 2021
@lgarron
Copy link
Author

@lgarron lgarron commented Oct 17, 2021

This seems to have resolved itself by now. 🤔

(But as documented with screenshots, it definitely was an issue for a while!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants