Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: install fossil, bzr, and gpg binaries on linux-*-longtest builders #48802

Closed
bcmills opened this issue Oct 5, 2021 · 7 comments
Closed
Labels
Builders NeedsFix
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 5, 2021

The go command at least nominally supports five different version control systems: Git, Mercurial, Subversion, Fossil, and Bazaar. Of those, only three appear to be installed on the linux-amd64-longtest builder. That all but guarantees that regressions in support for the other two will not be detected by the builders.

The two missing tools are Fossil (provided by the fossil Debian package), and Bazaar (somewhat confusingly, now provided by the brz Debian package).

CC @golang/release

@bcmills bcmills added Builders NeedsFix labels Oct 5, 2021
@bcmills bcmills added this to the Backlog milestone Oct 5, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 5, 2021

Change https://golang.org/cl/354149 mentions this issue: cmd/go: do not check for a built binary in TestScript/mod_get_fossil

gopherbot pushed a commit that referenced this issue Oct 5, 2021
This test hasn't passed since CL 349997, but the failure was not
detected because the Go project's builders do not have a 'fossil'
binary installed (#48802).

For #43684

Change-Id: I25544574ab48f4f146ae3795e541179e78815758
Reviewed-on: https://go-review.googlesource.com/c/go/+/354149
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
@bcmills bcmills changed the title x/build: install fossil binary on linux-*-longtest builders x/build: install fossil and bzr binaries on linux-*-longtest builders Dec 6, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 6, 2021

Change https://golang.org/cl/369743 mentions this issue: cmd/go: fix tests broken in CL 358539

gopherbot pushed a commit that referenced this issue Dec 7, 2021
CL 358539 revised the build-stamp format, and updated the git and hg
tests to match. However, the fossil and bzr tests were missed, and
were not caught on the builders due to the fact that none of the
builder images have the necessary VCS tools installed.

Updates #48802
Updates #49168

Change-Id: I6b9fd0e19b81cb539864c94ab0860f74e7be6748
Reviewed-on: https://go-review.googlesource.com/c/go/+/369743
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
@heschi heschi added this to Planned in Go Release Team Dec 7, 2021
@bcmills
Copy link
Member Author

@bcmills bcmills commented Jan 18, 2022

The presence of a gpg binary can also change the behavior of git, so gpg should probably be installed too.

@bcmills bcmills changed the title x/build: install fossil and bzr binaries on linux-*-longtest builders x/build: install fossil, bzr, and gpg binaries on linux-*-longtest builders Jan 18, 2022
@cagedmantis cagedmantis moved this from Planned to In Progress in Go Release Team Feb 8, 2022
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Feb 8, 2022

The linux-x86-bullseye image has been updated after the submission of go.dev/cl/383156. This issue should be resolved after we switch the linux longtest builders to use the updated Debian bullseye image.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 8, 2022

Change https://go.dev/cl/384295 mentions this issue: dashboard, env/linux-x86-bullseye: use Debian bullseye for linux-longtest builders

Go Release Team automation moved this from In Progress to Done Feb 9, 2022
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Feb 9, 2022

The image has been updated. The issue should be resolved after the next coordinator deployment.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 10, 2022

Change https://go.dev/cl/384934 mentions this issue: env/linux-x86-bullseye: add gpg-agent package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders NeedsFix
Projects
Development

No branches or pull requests

4 participants