Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: stack overflow in hasVarSize for invalid type [1.17 backport] #48825

Closed
gopherbot opened this issue Oct 6, 2021 · 11 comments
Closed
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link
Contributor

@findleyr requested issue #48819 to be considered for backport to the next 1.17 minor release.

@gopherbot please consider this for backport to 1.17, it's a regression.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 6, 2021
@gopherbot gopherbot added this to the Go1.17.2 milestone Oct 6, 2021
@mknyszek mknyszek modified the milestones: Go1.17.2, Go1.17.3 Oct 7, 2021
@thanm thanm modified the milestones: Go1.17.3, Go1.17.4 Nov 4, 2021
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Nov 24, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 24, 2021
@heschi
Copy link
Contributor

heschi commented Nov 24, 2021

@findleyr We've kicked this down the road for a while, does it still rate a cherrypick?

@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Ping. I plan to cut the minor releases tomorrow.

@findleyr
Copy link
Contributor

findleyr commented Dec 1, 2021

Sorry, thought I'd replied on this.

@griesemer would you be able to create a cherry-pick of CL 354349?

@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Update: I'm considering it, it's not set in stone yet. :) I'm trying to get a read on how many of these are very close to getting cherry picked. We already have a bunch of fixes that we should probably release soon.

@findleyr
Copy link
Contributor

findleyr commented Dec 1, 2021

FWIW I don't think our failure to land this cherry-pick should block a minor release, though I do still think we should fix this.

@griesemer
Copy link
Contributor

I'm on it.

@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

@findleyr Good to know. I wasn't planning on blocking, but I did want to give a heads-up.

@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/368456 mentions this issue: [release-branch.go1.17] go/types: break cycles in invalid types

@findleyr
Copy link
Contributor

findleyr commented Dec 1, 2021

@mknyszek the cherry-pick CL is ready. It contains a additional fix related to generics that wasn't in the main-line CL (because it was otherwise avoided). Normally that would be concerning, but since that code change was on the _TypeParam type, which won't be produced when type-checking non-generic code, we feel that this cherry-pick is still safe. The effective change is one line, and well understood.

However, neither @griesemer nor I have permission to merge this cherry pick. Could someone on @golang/release do it?

@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Done! (I do have permission.)

gopherbot pushed a commit that referenced this issue Dec 1, 2021
This is a partial port of CL 354329 from types2 to go/types.
It contains an adjustment to type.go to deal with possibly
invalid type bounds.

Fixes #48825.
For #48819.

Change-Id: I9efdcdbfa6432f3cee64d924a4c67ecc6793cf86
Reviewed-on: https://go-review.googlesource.com/c/go/+/354349
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/368456
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Ah, GopherBot is currently rate-limited. I'll close this manually to help keep track.

@mknyszek mknyszek closed this as completed Dec 1, 2021
@golang golang locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

6 participants