Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: -fuzzminimizetime={number}x doesn't work #48928

Closed
katiehockman opened this issue Oct 12, 2021 · 1 comment
Closed

testing: -fuzzminimizetime={number}x doesn't work #48928

katiehockman opened this issue Oct 12, 2021 · 1 comment
Labels
fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@katiehockman
Copy link
Contributor

katiehockman commented Oct 12, 2021

While testing locally, I noticed that -fuzzminimizetime doesn't work when running with something like 10x.

Even when -fuzzminimizetime is set to 10x, it runs many more times than that.

godev test -run Fuzz -fuzz Fuzz -fuzzminimizetime=10x
fuzz: elapsed: 0s, gathering baseline coverage: 0/25 completed
fuzz: elapsed: 0s, gathering baseline coverage: 25/25 completed, now fuzzing with 8 workers
fuzz: minimizing 1474-byte crash input...
fuzz: elapsed: 0s, minimizing
--- FAIL: FuzzFuzzer (0.15s)
        --- FAIL: FuzzFuzzer (0.00s)
            dsa_test.go:19: minimize this! 0, len(s)=478
        --- FAIL: FuzzFuzzer (0.00s)
            dsa_test.go:19: minimize this! 0, len(s)=478
.... this goes on for a while
        --- FAIL: FuzzFuzzer (0.00s)
            dsa_test.go:19: minimize this! 0, len(s)=4
        --- FAIL: FuzzFuzzer (0.00s)
            dsa_test.go:19: minimize this! 0, len(s)=3
        --- FAIL: FuzzFuzzer (0.00s)
            dsa_test.go:19: minimize this! 0, len(s)=2
        --- FAIL: FuzzFuzzer (0.00s)
            dsa_test.go:19: minimize this! 0, len(s)=1
    
    Crash written to testdata/fuzz/FuzzFuzzer/d8398164056fc45958535f08a1b29a7fd10a21f12c95b34d4b891c6f9842b6d3
    To re-run:
    go test foo -run=FuzzFuzzer/d8398164056fc45958535f08a1b29a7fd10a21f12c95b34d4b891c6f9842b6d3
FAIL
exit status 1
FAIL    foo      0.317s

/cc @golang/fuzzing

@katiehockman katiehockman added NeedsFix The path to resolution is known, but the work has not been done. release-blocker fuzz Issues related to native fuzzing support labels Oct 12, 2021
@katiehockman katiehockman added this to the Go1.18 milestone Oct 12, 2021
@katiehockman katiehockman self-assigned this Oct 12, 2021
@gopherbot
Copy link

gopherbot commented Oct 12, 2021

Change https://golang.org/cl/355450 mentions this issue: internal/fuzz: fix -fuzzminimizetime with 'x' bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Status: No status
Development

No branches or pull requests

2 participants