-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: unable to fetch packages from module proxy (go.buf.build) #48952
Comments
Following CL 245918 pkg.go.dev does not process modules with zero commit times. The proxy does support them, maybe this is something we should revisit? I'm not sure of the exact motivation behind the change. |
go.buf.build would also need to include a license for the generated code |
I now believe this is our bug. We should handle zero commit times. |
Change https://golang.org/cl/356129 mentions this issue: |
@jba has your fix been deployed, or is there perhaps another issue? I'm still getting "could not be found" messages for the packages in the issue summary. If there is not a valid license, I believe I should see a message to that effect. |
The fix hasn't been deployed yet. I'll ping this issue when the problem is resolved. (As per standard but confusing GitHub etiquette, the issue gets closed when the fixing PR is submitted, not when the problem is actually fixed.) |
@jba great, thanks! I appreciate it. |
This is fixed. (You still have a license problem.) |
What is the URL of the page with the issue?
https://pkg.go.dev/go.buf.build/library/go-grpc/envoyproxy/protoc-gen-validate/validate
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.71 Safari/537.36
Screenshot
Clicking the "Request" button leads to:
What did you do?
Attempted to view documentation for any package available through go.buf.build, a module proxy.
What did you expect to see?
Generated documentation for the package, e.g.:
https://godocs.io/go.buf.build/library/go-grpc/envoyproxy/protoc-gen-validate/validate
What did you see instead?
The "Oops!" page as seen in the above screenshots.
I've tried following each of the linked instructions to fetch the package but none appear to succeed.
godocs.io seems to handle this fine, so I am not sure if the problem is with pkgsite or go.buf.build. If it's the latter, any guidance on what's incorrect would be much appreciated.
The text was updated successfully, but these errors were encountered: