Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto: p256MulInternal and p256SqlInternal look like they could benefit from AVX-512 #48986

Open
jwinkler2083233 opened this issue Oct 14, 2021 · 1 comment
Open

x/crypto: p256MulInternal and p256SqlInternal look like they could benefit from AVX-512 #48986

jwinkler2083233 opened this issue Oct 14, 2021 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance
Milestone
Unreleased

Comments

@jwinkler2083233
Copy link

What version of Go are you using (go version)?

go version go1.16.7 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

recent Linux / amd64

What did you do?

I ran performance profiles that involve the crypto library in Go.

I'm seeing unexpected bottlenecks in p256MulInternal and p256SqrInternal. Looking at the code, it seems that these would benefit from AVX-512 instructions.
@toothrot toothrot changed the title p256MulInternal and p256SqlInternal look like they could benefit from AVX-512 x/crypto: p256MulInternal and p256SqlInternal look like they could benefit from AVX-512 Oct 15, 2021
@gopherbot gopherbot added this to the Unreleased milestone Oct 15, 2021
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 15, 2021
@andig
Copy link
Contributor

andig commented Oct 15, 2021

Add performance tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@toothrot @andig @randall77 @gopherbot @jwinkler2083233