Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: audit lock/atomic-free accesses in pollDesc #49008

Open
prattmic opened this issue Oct 15, 2021 · 0 comments
Open

runtime: audit lock/atomic-free accesses in pollDesc #49008

prattmic opened this issue Oct 15, 2021 · 0 comments
Assignees
@prattmic
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@prattmic
Copy link
Member

prattmic commented Oct 15, 2021

#48925 identified a bug that was ultimately due to non-atomic access to pollDesc.rg/pollDesc.wg. This is fixed by https://golang.org/cl/355952, but pollDesc is full of other fields accessed non-atomically which may be problematic (everr stands out to me as suspicious), plus many fields that are almost always protected by the lock.

We should vet the current fields for issues, and clean up the documentation and semantics for better maintainability.

cc @mknyszek
@prattmic prattmic added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 15, 2021
@prattmic prattmic added this to the Backlog milestone Oct 15, 2021
@prattmic prattmic self-assigned this Oct 15, 2021
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prattmic prattmic

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Todo
Milestone
Backlog
Development

No branches or pull requests
2 participants
@prattmic @gopherbot