Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fuzz,testing: apparent deadlock in test_fuzz_fuzztime #49046

Closed
bcmills opened this issue Oct 18, 2021 · 3 comments
Closed

internal/fuzz,testing: apparent deadlock in test_fuzz_fuzztime #49046

bcmills opened this issue Oct 18, 2021 · 3 comments
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 18, 2021

greplogs --dashboard -md -l -e '(?ms)FAIL: TestScript/test_fuzz_fuzztime.*test timed out'

2021-10-14T17:38:39-011fd00/linux-386-longtest
2021-10-05T20:57:56-55e7f7e/linux-386-longtest
2021-09-27T18:23:35-40fce51/linux-386-longtest
2021-09-22T15:46:33-5ee32ff/linux-386-longtest

This also occurred in a linux-amd64-longtest TryBot, so it doesn't seem to be specific to 386.
(https://storage.googleapis.com/go-build-log/a2ef59d2/linux-amd64-longtest_9d302f57.log)

CC @katiehockman @rolandshoemaker
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker fuzz Issues related to native fuzzing support labels Oct 18, 2021
@bcmills bcmills added this to the Go1.18 milestone Oct 18, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/356649 mentions this issue: cmd/go: skip flaky fuzz tests

@bcmills bcmills changed the title internal/fuzz: apparent deadlock in test_fuzz_fuzztime internal/fuzz,testing: apparent deadlock in test_fuzz_fuzztime Oct 18, 2021
@katiehockman katiehockman added Testing An issue that has been verified to require only test changes, not just a test failure. and removed Testing An issue that has been verified to require only test changes, not just a test failure. labels Oct 19, 2021
gopherbot pushed a commit that referenced this issue Oct 19, 2021
cmd/go: skip flaky fuzz tests
6294207 
(Temporarily, until they can be fixed.)

For #49046
For #49047

Change-Id: Ib580a5e45a0955aabdfc1899ed38a262a37f66ab
Reviewed-on: https://go-review.googlesource.com/c/go/+/356649
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
@katiehockman katiehockman self-assigned this Oct 22, 2021
@katiehockman katiehockman added the Testing An issue that has been verified to require only test changes, not just a test failure. label Oct 22, 2021
@katiehockman
Copy link
Contributor

katiehockman commented Oct 22, 2021 •
edited
Loading

This is an issue with the test. The point of the test is to make sure that test.timeout doesn't have an impact when fuzzing.
The test is setting a very small test.timeout of 10ms when fuzzing. The test is expecting an exit code of 0, but if the timeout of 10ms is reached before stopAlarm() is called (after all the tests, examples, and other fuzz targets have run), then the test will panic. Increasing the test.timeout should suffice to fix this. If it doesn't, then we can think more about how to deflake a bit better.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/358055 mentions this issue: cmd/go/testdata/script: fix flaky test_fuzz_fuzztime test

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Security
Status: No status
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @katiehockman