Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: optimize memmove for 1-16 MB overlapping case on AMD64 #49058

Open
weishi-deng opened this issue Oct 19, 2021 · 1 comment
Open

runtime: optimize memmove for 1-16 MB overlapping case on AMD64 #49058

weishi-deng opened this issue Oct 19, 2021 · 1 comment

Comments

@weishi-deng
Copy link

@weishi-deng weishi-deng commented Oct 19, 2021

What version of Go are you using (go version)?

$ go1.16.4

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build287939000=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I run some test cases using function 'runtime.memmove' when data size is over 1MB and below 16MB with address overlap.

What did you expect to see?

'runtime.memmove' choose the most efficient way (from the non-temporal store and temporal store) to copy data.

What did you see instead?

When the test case is with address overlap and the size is over 1MB and below 16MB, the non-temporal store copying is slower than temporal store copying, but 'runtime.memmove' chooses to copy data using non-temporal store copying.

@ALTree ALTree added this to the Unplanned milestone Oct 19, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 19, 2021

Change https://golang.org/cl/356749 mentions this issue: runtime: use non-temporal store copying for size over 16MB and use temporal store copying for size is 1MB ~ 16MB in'memmove'.

Loading

@cherrymui cherrymui changed the title runtime: update for memmove runtime: optimize memmove for 1-16 MB overlapping case on AMD64 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants