Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: search redesign - remove module path in "other major versions" #49069

Closed
julieqiu opened this issue Oct 19, 2021 · 2 comments
Closed

x/pkgsite: search redesign - remove module path in "other major versions" #49069

julieqiu opened this issue Oct 19, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Milestone
pkgsite/search

Comments

@julieqiu
Copy link
Member

What is the URL of the page with the issue?

https://beta.pkg.go.dev/search?q=github&m=package

Screenshot

Screen Shot 2021-10-19 at 1 24 42 PM

What did you expect to see?

Instead of:

Other major versions: github.com/google/go-github/v38 github.com/google/go-github/v37 github.com/google/go-github/v36 github.com/google/go-github/v35 github.com/google/go-github/v34 github.com/google/go-github/v33 github.com/google/go-github/v32 github.com/google/go-github/v31 github.com/google/go-github/v30 github.com/google/go-github/v29 github.com/google/go-github/v28 github.com/google/go-github/v27 github.com/google/go-github/v26 github.com/google/go-github/v25 github.com/google/go-github/v24 github.com/google/go-github

We should show:

Other major versions: v38 v37 v35 v34 v33 v32 v31 v30 v29 v28 v27 v26 v25 v24 v0

We can determine if v0 or v1 should be shown in the case of the first major version by looking at the latest version of that module.
@julieqiu julieqiu added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Oct 19, 2021
@julieqiu julieqiu added this to the pkgsite/search milestone Oct 19, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/357290 mentions this issue: internal/postgres: record other module versions in SearchResult

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/357349 mentions this issue: internal/frontend: display other module links as "vN"

gopherbot pushed a commit to golang/pkgsite that referenced this issue Oct 25, 2021
@jba
internal/postgres: record other module versions in SearchResult
eb310f7 
Previously, a SearchResult stored only the paths of modules at other
major versions.  Now it remembers the major versions as well.

This CL doesn't change any UI, but it is preparation for displaying
the major versions of other modules instead of their paths.

For golang/go#49069

Change-Id: I510eeb27aaab1b8764c72434760265d4c6ee9359
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/357290
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@hyangah hyangah added the pkgsite/search Issues related to pkg.go.dev search functionality label May 20, 2022
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Milestone
pkgsite/search
Development

No branches or pull requests
4 participants
@hyangah @julieqiu @gopherbot @jba