Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: -buildmode=pie -linkshared panic at runtime [1.17 backport] #49086

Closed
gopherbot opened this issue Oct 20, 2021 · 5 comments
Closed

cmd/link: -buildmode=pie -linkshared panic at runtime [1.17 backport] #49086

gopherbot opened this issue Oct 20, 2021 · 5 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 20, 2021

@zhouguangyuan0718 requested issue #47873 to be considered for backport to the next 1.17 minor release.

@gopherbot please consider this for backport to 1.17, maybe we need fix it for 1.17.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 20, 2021

Change https://golang.org/cl/357231 mentions this issue: cmd/link: disable weak reference in itab if build with "-linkshared"

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 28, 2021

The backport policy requires both supported releases, Go 1.17 and 1.16 at this time, to be supported equally (see https://golang.org/issue/34536#issuecomment-572188389). So to proceed here we need to check if this bug is also present in 1.16, or if it was a regression introduced in Go 1.17.

@zhouguangyuan0718 Do you know if the problem also affects Go 1.16?

Loading

@zhouguangyuan0718
Copy link
Contributor

@zhouguangyuan0718 zhouguangyuan0718 commented Oct 28, 2021

The backport policy requires both supported releases, Go 1.17 and 1.16 at this time, to be supported equally (see https://golang.org/issue/34536#issuecomment-572188389). So to proceed here we need to check if this bug is also present in 1.16, or if it was a regression introduced in Go 1.17.

@zhouguangyuan0718 Do you know if the problem also affects Go 1.16?

This bug is present after https://go-review.googlesource.com/c/go/+/268479 summited.
It doesn't affect Go 1.16.

More detailed analysis is here: #47873 (comment).
@dmitshur

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 28, 2021

Thanks for pointing that out. We can proceed with the backport CL, as only 1.17 needs the fix then.

Loading

gopherbot pushed a commit that referenced this issue Oct 28, 2021
…uild with "-linkshared"

When build with "-linkshared", we can't tell if the interface method will be used or not. It can be used in shared library.
This CL backport this fix to 1.17.

Fixes #49086

Change-Id: Iba12812f199b7679cf2fd41a304268d6d6dd03c6
Reviewed-on: https://go-review.googlesource.com/c/go/+/350189
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
(cherry picked from commit f687831)
Reviewed-on: https://go-review.googlesource.com/c/go/+/357231
Trust: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 28, 2021

Closed by merging 91aa2f1 to release-branch.go1.17.

Loading

@gopherbot gopherbot closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants