Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: consolidate error message formats #49123

Open
griesemer opened this issue Oct 23, 2021 · 4 comments
Open

go/types, types2: consolidate error message formats #49123

griesemer opened this issue Oct 23, 2021 · 4 comments
Assignees
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@griesemer
Copy link
Contributor

Error messages don't have a particular "style guide" at the moment:

  • there are simple errors of the form: func main must have no arguments and no return values
  • there are errors with clarifications using a :: undefined: x
  • there are errors with clarifications using a ;: cannot make int; type must be slice, map, or channel
  • there are errors with clarifications using parentheses: cannot slice s (variable of type chan int)
  • there are errors with clarifications on separate lines, indented, possible combined with any of the forms above

Maybe we can come up with a reasonably consistent set of rules for how to format errors (e.g., when to use ':', ';', or parentheses). If we can, that we should be able to encode this for consistent behavior.

@griesemer griesemer added NeedsFix The path to resolution is known, but the work has not been done. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Oct 23, 2021
@griesemer griesemer added this to the Backlog milestone Oct 23, 2021
@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Oct 23, 2021
@griesemer griesemer modified the milestones: Backlog, Go1.19 Mar 18, 2022
@griesemer
Copy link
Contributor Author

Too late for 1.19.

@griesemer griesemer modified the milestones: Go1.19, Go1.20 Jun 24, 2022
@findleyr findleyr modified the milestones: Go1.20, Go1.21 Nov 10, 2022
@findleyr
Copy link
Contributor

This isn't getting done for 1.21. Move to 1.22?

@griesemer griesemer modified the milestones: Go1.21, Go1.22 May 23, 2023
@griesemer
Copy link
Contributor Author

Moving to 1.23.

@griesemer griesemer modified the milestones: Go1.22, Go1.23 Nov 7, 2023
@griesemer
Copy link
Contributor Author

Too late for sweeping changes. Moving to 1.24.

@griesemer griesemer modified the milestones: Go1.23, Go1.24 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
Status: No status
Development

No branches or pull requests

3 participants