Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: internal compiler error: can't find source for b12->b4: v31 = MOVBload <bool> v14 v1 : DX [1.17 backport] #49129

Closed
gopherbot opened this issue Oct 23, 2021 · 5 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 23, 2021

@randall77 requested issue #49122 to be considered for backport to the next 1.17 minor release.

@gopherbot please open a backport issue for 1.17.

@randall77
Copy link
Contributor

@randall77 randall77 commented Oct 23, 2021

This bug is rare but causes a serious miscompilation.

Loading

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 23, 2021

Change https://golang.org/cl/358118 mentions this issue: cmd/compile: fix fuse pass to do CFG surgery correctly

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 27, 2021

From reading #49122 I understand that this was a regression in 1.17, so 1.16 doesn't need this backport since it doesn't have the bug (please correct if that's not the case).

Loading

@randall77
Copy link
Contributor

@randall77 randall77 commented Oct 27, 2021

That is correct.

Loading

@thanm thanm removed this from the Go1.17.3 milestone Nov 4, 2021
@thanm thanm added this to the Go1.17.4 milestone Nov 4, 2021
gopherbot pushed a commit that referenced this issue Nov 24, 2021
…correctly

removePred and removeArg do different things. removePred moves the last
predecessor to index k, whereas removeArg slides all the args k or
greater down by 1 index.

Kind of unfortunate different behavior in things named similarly.

Fixes #49129

Change-Id: I9ae409bdac744e713f4c121f948e43db6fdc8542
Reviewed-on: https://go-review.googlesource.com/c/go/+/358117
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
(cherry picked from commit 8dbf3e9)
Reviewed-on: https://go-review.googlesource.com/c/go/+/358118
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Nov 24, 2021

Closed by merging 1c05b9b to release-branch.go1.17.

Loading

@gopherbot gopherbot closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants