Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: remove retracted module versions from search #49148

Closed
julieqiu opened this issue Oct 25, 2021 · 3 comments
Closed

x/pkgsite: remove retracted module versions from search #49148

julieqiu opened this issue Oct 25, 2021 · 3 comments
Assignees
@jamalc
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Member

The latest version of github.com/tredoe/osutil is v1.0.6, but the version that appears in search is v1.3.5. This is because v1.3.5 is retracted. We should remove retracted versions from search_documents.

https://pkg.go.dev/github.com/tredoe/osutil
Screen Shot 2021-10-25 at 12 05 20 PM

https://pkg.go.dev/search?q=tredoe%2Fosutil
Screen Shot 2021-10-25 at 12 06 08 PM

https://pkg.go.dev/github.com/tredoe/osutil@v1.3.5.
Screen Shot 2021-10-25 at 12 06 52 PM

/cc @golang/pkgsite
@gopherbot gopherbot added this to the Unreleased milestone Oct 25, 2021
@jba jba self-assigned this Oct 25, 2021
@bcmills
Copy link
Contributor

bcmills commented Oct 26, 2021

See previously #47590 — perhaps there was a bug in the fix for that?

@jamalc jamalc added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 10, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Dec 10, 2021
@jba jba assigned jamalc and unassigned jba Jul 11, 2022
@thanethomson thanethomson mentioned this issue Sep 3, 2022
Closed
@bcmills
Copy link
Contributor

bcmills commented Aug 14, 2023

https://pkg.go.dev/search?q=tredoe%2Fosutil is no longer showing the retracted module. @jamalc, is this fixed?

@jamalc
Copy link

jamalc commented Aug 14, 2023

Yes, this was fixed in https://golang.org/cl/341591. Thanks!

@jamalc jamalc closed this as completed Aug 14, 2023
@golang golang locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jamalc jamalc

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
5 participants
@bcmills @julieqiu @gopherbot @jamalc @jba