Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/analysis/passes/httpresponse: Test fails on "typeparams" test case with 1.17/1.16 #49160

Closed
dmitshur opened this issue Oct 26, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@dmitshur
Copy link
Contributor

As of CL 358696, Test passes on tip but fails with Go 1.17 and 1.16 (as detected on build.golang.org, see log) with:

-: build constraints exclude all Go files in /tmp/buildlet/gopath/src/golang.org/x/tools/go/analysis/passes/httpresponse/testdata/src/typeparams
--- FAIL: Test (2.32s)
    analysistest.go:296: error analyzing httpresponse@typeparams: analysis skipped due to errors in package
FAIL
FAIL	golang.org/x/tools/go/analysis/passes/httpresponse	2.448s

Said file has a //go:build go1.18 build constraint and likely isn't meant to be tested with older Go versions.

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Oct 26, 2021
@dmitshur dmitshur added this to the Unreleased milestone Oct 26, 2021
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Oct 26, 2021
@gopherbot

This comment has been minimized.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/358698 mentions this issue: go/analysis/passes/httpresponse: fix a testing issue.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 26, 2021
@golang golang locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants