Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: revise build stamp keys for Go 1.18 #49168

Open
bcmills opened this issue Oct 26, 2021 · 3 comments
Open

cmd/go: revise build stamp keys for Go 1.18 #49168

bcmills opened this issue Oct 26, 2021 · 3 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 26, 2021

In #37475 (comment), @mpx notes that the keys used to record build stamp information are a bit inconsistent: we currently use gitrevision, hgrevision, etc. for each vcs, and uncommitted for all VCSs.

I discussed with @rsc and @matloob, and we are planning to revise these setting-names both to make the VCS settings a bit more uniform and to more clearly distinguish between flags and other metadata. (@rsc may do this as a further patch-set on CL 358539.)

@mpx
Copy link
Contributor

@mpx mpx commented Oct 27, 2021

To clarify: We always prepend the VCS name before revision, uncommitted, and committime. I think it would be better to set a vcs tag and stop prepending the name to other keys. committime and uncommitted (even revision) are basically the same across VCS, and using consistent names makes them much easier to consume. It's unlikely we ever want to support simultaneously tagging for multiple VCS.

Loading

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 12, 2021

This is mostly done in CL 358539, but it needs a test-fix before it can be merged.

Loading

@heschi
Copy link
Contributor

@heschi heschi commented Nov 24, 2021

The beta is getting close and this is currently marked as blocking the beta. Any news here?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants