Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: double traceGCSweepStart failure on builders #49231

Closed
mknyszek opened this issue Oct 29, 2021 · 1 comment
Closed

runtime: double traceGCSweepStart failure on builders #49231

mknyszek opened this issue Oct 29, 2021 · 1 comment
Labels
NeedsFix release-blocker
Milestone

Comments

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Oct 29, 2021

https://golang.org/cl/359775 erroneously moved the corresponding traceGCSweepDone that's missing here into a conditional block, but this event needs to be produced unconditionally, since the corresponding GCSweepStart is produced unconditionally.

Example failure: https://build.golang.org/log/8e3d76719ad974ebda98cef2b9ceab3cbc23de45

The fix is straightforward. It's incoming...

@mknyszek mknyszek added NeedsFix release-blocker labels Oct 29, 2021
@mknyszek mknyszek added this to the Go1.18 milestone Oct 29, 2021
@mknyszek mknyszek self-assigned this Oct 29, 2021
@mknyszek mknyszek changed the title runtime: double traceGCSweepStart flake on builders runtime: double traceGCSweepStart failure on builders Oct 29, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 29, 2021

Change https://golang.org/cl/359775 mentions this issue: runtime: fix unclosed GCSweepStart trace event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants