Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: assertWorldStoppedOrLockHeld failed in GC pacer tests #49234

Closed
mknyszek opened this issue Oct 29, 2021 · 1 comment
Closed

runtime: assertWorldStoppedOrLockHeld failed in GC pacer tests #49234

mknyszek opened this issue Oct 29, 2021 · 1 comment
Labels
NeedsFix release-blocker
Milestone
Go1.18

Comments

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Oct 29, 2021

https://golang.org/cl/353354 adds tests for the GC pacer, but doesn't stub out lock held assertions, causing the staticlockranking builder to fail.

The fix is straightforward and incoming.
@mknyszek mknyszek self-assigned this Oct 29, 2021
@mknyszek mknyszek added NeedsFix release-blocker labels Oct 29, 2021
@mknyszek mknyszek added this to the Go1.18 milestone Oct 29, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 29, 2021

Change https://golang.org/cl/359878 mentions this issue: runtime: disable pacer lock held assertions in tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot