-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: TestCloseWrite failures with "i/o timeout" on darwin/arm64 #49352
Comments
Still ongoing (but rare) on
(attn @neild, @ianlancetaylor) |
I wonder if this is a variation on #37795? |
The mips64le failure above has "too many open files" in the log, and is likely unrelated. I'll bet this is the same macOS bug as #37795. If it is, a similar workaround might work--add a small delay so that we don't close (or |
Seems worth a shot, at least! (We can always try it, and reopen the issue if it turns out not to be the right workaround.) |
Change https://go.dev/cl/414534 mentions this issue: |
Sent https://go.dev/cl/414534 with a port of the workaround from #37795, prompted by another failure on the dashboard.
|
Unless I'm misunderstanding something, this recurred on 6/29: 2022-06-29T22:28:30-b2cc0fe/darwin-arm64-11 |
On darwin_arm64, reading from a socket at the same time as the other end is closing it will occasionally hang for 60 seconds before returning ECONNRESET. (This is a macOS issue, not a Go issue.) Work around this condition by adding a brief sleep before the read. Fixes golang#49352 (we hope). Updates golang#37795. Change-Id: I4052aec21d311d7370550aea9dd7941f39141133 Reviewed-on: https://go-review.googlesource.com/c/go/+/414534 Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
|
Found new dashboard test flakes for:
2023-02-10 17:30 darwin-arm64-12 go@f69dbb6d net.TestCloseWrite (log)
|
(Note that the above failure was on |
If this is indeed #37795, then I believe we should stop seeing this on more recent Darwin versions. (macOS 13 and higher? Not sure which version has the fix.) |
Found new dashboard test flakes for:
2023-05-16 19:46 darwin-arm64-12 go@b3d1cce3 net.TestCloseWrite (log)
|
Found new dashboard test flakes for:
2023-05-19 22:45 darwin-arm64-12 go@fe786638 net.TestCloseWrite (log)
|
Found new dashboard test flakes for:
2023-10-13 17:10 darwin-arm64-12 go@6dd7462a net.TestCloseWrite (log)
|
Found new dashboard test flakes for:
2024-03-28 21:12 darwin-arm64-11 go@4edf4bb2 net.TestCloseWrite (log)
|
Found new dashboard test flakes for:
2024-04-15 17:26 darwin-arm64-12 go@55e4097c net.TestCloseWrite (log)
|
greplogs --dashboard -md -l -e '(?m)FAIL: TestCloseWrite/.*\n(\s+.*\n)*.*i/o timeout'
2021-11-03T21:45:33-d3f5dd5/darwin-arm64-11_0-toothrot
2020-10-20T17:52:41-90c924f/ios-arm64-corellium
2020-09-28T21:30:01-af18bce/linux-mips64le-mengzhuo
2020-09-07T02:46:24-1a119ed/darwin-arm64-corellium
2020-08-26T16:15:32-6382809/darwin-arm64-corellium
2020-08-18T15:50:52-b58d297/darwin-arm64-corellium
2020-05-01T19:55:48-30f8074/darwin-arm64-corellium
2020-04-13T21:56:15-1b15c7f/darwin-arm64-corellium
See previously #34837.
The text was updated successfully, but these errors were encountered: