Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestTracebackArgs failure for testTracebackArgs9 #49354

Closed
bcmills opened this issue Nov 4, 2021 · 3 comments
Closed

runtime: TestTracebackArgs failure for testTracebackArgs9 #49354

bcmills opened this issue Nov 4, 2021 · 3 comments
Labels
NeedsInvestigation okay-after-beta1 release-blocker
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 4, 2021

greplogs --dashboard -md -l -e 'FAIL: TestTracebackArgs' --since=2021-10-28T15:08:00

2021-11-04T00:15:11-6049630/darwin-amd64-10_15

testTracebackArgs9 is one of the cases added for #45728 in Go 1.18 (CC @cherrymui @mknyszek).

@bcmills bcmills added NeedsInvestigation okay-after-beta1 release-blocker labels Nov 4, 2021
@bcmills bcmills added this to the Go1.18 milestone Nov 4, 2021
@cherrymui
Copy link
Member

@cherrymui cherrymui commented Nov 4, 2021

Thanks. I have a guess. Will send a CL.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 4, 2021

Change https://golang.org/cl/361211 mentions this issue: runtime: mark TestTracebackArgs test functions nosplit

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 5, 2021

Change https://golang.org/cl/361212 mentions this issue: cmd/dist: add maymorestack tests

gopherbot pushed a commit that referenced this issue Apr 25, 2022
These tests run the runtime, reflect, and sync package tests with the
two maymorestack hooks we have.

These tests only run on the longtest builders (or with
GO_TEST_SHORT=false) because we're running the runtime test two
additional times and the mayMoreStackMove hook makes it about twice as
slow (~230 seconds).

To run just these tests by hand, do

  GO_TEST_SHORT=false go tool dist test -run mayMoreStack

Updates #48297.

This detected #49354, which was found as a flake on the dashboard, but
was reliably reproducible with these tests; and #49395.

Change-Id: If785a8b8d6e1b9ad4d2ae67493b54055ab6cbc85
Reviewed-on: https://go-review.googlesource.com/c/go/+/361212
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation okay-after-beta1 release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants