Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/netip: zero value of Addr is undocumented #49364

Closed
FiloSottile opened this issue Nov 4, 2021 · 2 comments
Closed

net/netip: zero value of Addr is undocumented #49364

FiloSottile opened this issue Nov 4, 2021 · 2 comments
Labels
Documentation NeedsFix release-blocker
Milestone

Comments

@FiloSottile
Copy link
Contributor

@FiloSottile FiloSottile commented Nov 4, 2021

The zero value of Addr is not documented (is it 0.0.0.0? is it invalid?) but is referred to in some docs.

If slice's length is not 4 or 16, AddrFromSlice returns Addr{}, false.

@FiloSottile FiloSottile added this to the Go1.18 milestone Nov 4, 2021
@ianlancetaylor ianlancetaylor added NeedsFix release-blocker labels Nov 4, 2021
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 4, 2021

CC @bradfitz @josharian

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 5, 2021

Change https://golang.org/cl/361914 mentions this issue: net/netip: document the zero Addr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation NeedsFix release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants