Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: internal compiler error: Op...LECall and OpDereference have mismatched mem [1.17 backport] #49413

Closed
gopherbot opened this issue Nov 6, 2021 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Nov 6, 2021

@hanchaoqun requested issue #49282 to be considered for backport to the next 1.17 minor release.

@gopherbot Please open backport to 1.16 and 1.17

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 6, 2021
@gopherbot gopherbot added this to the Go1.17.4 milestone Nov 6, 2021
@gopherbot
Copy link
Author

gopherbot commented Nov 6, 2021

Change https://golang.org/cl/362054 mentions this issue: [release-branch.go1.17] cmd/compile: avoid adding LECall to the entry block when has opendefers

@cagedmantis
Copy link
Contributor

cagedmantis commented Nov 10, 2021

@drchase left a comment stating that this is reproducible in 1.16.

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Nov 24, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 24, 2021
@heschi
Copy link
Contributor

heschi commented Nov 24, 2021

@dr2chase This cherrypick's CL still needs review.

@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Ping. I plan to cut the minor releases tomorrow.

@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Update: I'm considering it, it's not set in stone yet. :)

@heschi heschi modified the milestones: Go1.17.4, Go1.17.5 Dec 2, 2021
@toothrot toothrot modified the milestones: Go1.17.5, Go1.17.6 Dec 9, 2021
@gopherbot
Copy link
Author

gopherbot commented Dec 21, 2021

Closed by merging ebd1b4d to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Dec 21, 2021
… block when has opendefers

The openDeferRecord always insert vardef/varlive pairs into the entry block, it may destroy the mem chain when LECall's args are writing into the same block. So create a new block before that happens.

Fixes #49413

Change-Id: Ibda6c4a45d960dd412a641f5e02276f663c80785
Reviewed-on: https://go-review.googlesource.com/c/go/+/361410
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Trust: Than McIntosh <thanm@google.com>
Reviewed-by: David Chase <drchase@google.com>
(cherry picked from commit 4f083c7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/362054
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Development

No branches or pull requests

5 participants