Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: inconsistent error messages for Scan() and friends. #4944

Closed
kisielk opened this issue Feb 28, 2013 · 4 comments
Closed

fmt: inconsistent error messages for Scan() and friends. #4944

kisielk opened this issue Feb 28, 2013 · 4 comments
Assignees
Milestone

Comments

@kisielk
Copy link
Contributor

@kisielk kisielk commented Feb 28, 2013

Some errors are prefixed by "Scan:", some are not. For an example, see:
http://play.golang.org/p/ZvGqu_unuk

Looking at calls to errorString in scan.go it looks like most are not prefixed by Scan
but there are still 6 cases that are.  

Should the error messages be prefixed with "Scan:" or not? I think it makes it
easier to format in to other messages if they are not. I can prepare the CL if there is
agreement.
@rsc
Copy link
Contributor

@rsc rsc commented Mar 12, 2013

Comment 1:

[The time for maybe has passed.]

Labels changed: removed go1.1maybe.

@dsymonds
Copy link
Member

@dsymonds dsymonds commented Jun 4, 2013

Comment 2:

Labels changed: added priority-soon, packagebug, removed priority-triage.

Owner changed to @robpike.

@rsc
Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 3:

Labels changed: added go1.2.

Status changed to Accepted.

@robpike
Copy link
Contributor

@robpike robpike commented Jul 31, 2013

Comment 4:

This issue was closed by revision 609d742.

Status changed to Fixed.

@kisielk kisielk added fixed labels Jul 31, 2013
@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.