Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: keyboard shortcuts don't work on some pages #49455

Closed
lrewega opened this issue Nov 8, 2021 · 4 comments
Closed

x/pkgsite: keyboard shortcuts don't work on some pages #49455

lrewega opened this issue Nov 8, 2021 · 4 comments
Labels
FrozenDueToAge pkgsite
Milestone
pkgsite/unplanned

Comments

@lrewega
Copy link

lrewega commented Nov 8, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/Shopify/sarama

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36

Screenshot

n/a

What did you do?

  • Pressed f to summon the "Jump To" modal.
  • Pressed ? or clicked the keyboard icon at the bottom of the page.

What did you expect to see?

  • A "Jump To" modal.
  • A keyboard shortcuts modal.

What did you see instead?

Nothing.

I'm guessing it has something to do with large pages/packages.
@gopherbot gopherbot added this to the pkgsite/unplanned milestone Nov 8, 2021
@jamalc jamalc self-assigned this Nov 12, 2021
@jamalc jamalc mentioned this issue Nov 12, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/363735 mentions this issue: static: delay modal initialization

@earthboundkid
Copy link
Contributor

This is still broken for me with Safari.

@jamalc jamalc reopened this Jan 12, 2022
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/378096 mentions this issue: static/shared/modal: fix modal errors

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/378095 mentions this issue: third_party: update dialog polyfill

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 13, 2022
@jamalc
third_party: update dialog polyfill
3960c26 
For golang/go#49556
For golang/go#49455

Change-Id: I6404c1b6075ac24fd7e0c7706a71ff10fdb2c7f8
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/378095
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@rsc rsc unassigned jamalc Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@earthboundkid @lrewega @gopherbot @jamalc