Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: reentrant nanotime and walltime may return bogus time on ARM #49481

Closed
prattmic opened this issue Nov 9, 2021 · 1 comment
Closed

runtime: reentrant nanotime and walltime may return bogus time on ARM #49481

prattmic opened this issue Nov 9, 2021 · 1 comment
Labels
arch-arm NeedsFix

Comments

@prattmic
Copy link
Member

@prattmic prattmic commented Nov 9, 2021

https://golang.org/cl/246763 made nanotime and walltime reentrant, but on ARM, the calculation of the result used a register expected to be zero which was changed by https://golang.org/cl/246763 to the old value of vdsoSP. This is usually 0, but in a reentrant call would not be, thus generating a bogus result.

I already fixed walltime in https://golang.org/cl/361159, but nanotime has a similar issue.

cc @cherrymui

@prattmic prattmic added NeedsFix arch-arm labels Nov 9, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 9, 2021

Change https://golang.org/cl/362674 mentions this issue: runtime: add upper half and carry bit with zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm NeedsFix
Projects
None yet
Development

No branches or pull requests

2 participants