Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: create windows-386-2012 builder #49490

Closed
cagedmantis opened this issue Nov 9, 2021 · 3 comments
Closed

x/build: create windows-386-2012 builder #49490

cagedmantis opened this issue Nov 9, 2021 · 3 comments
Labels
Builders NeedsFix new-builder release-blocker
Milestone

Comments

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Nov 9, 2021

The Go1.18 release will require a supported version of Windows to be released on. While Windows Server 2012 does not have native i386 support, Microsoft Windows-32-on-Windows-64 (WOW64) allows you to run 32 bit software on an x64 system.

@golang/release

@cagedmantis cagedmantis added Builders NeedsFix new-builder labels Nov 9, 2021
@cagedmantis cagedmantis added this to the Go1.18 milestone Nov 9, 2021
@cagedmantis cagedmantis self-assigned this Nov 9, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 11, 2021

Change https://golang.org/cl/363474 mentions this issue: dashboard: add windows-386-2012 builder

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 23, 2021

I think that CL went a bit too far. Adding a newer builder is good. But removing 2008 from trybots is maybe less good. That will surely bitrot Windows 7 support after some time.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 23, 2021

Change https://golang.org/cl/366656 mentions this issue: dashboard: do not sunset windows 2008

gopherbot pushed a commit to golang/build that referenced this issue Nov 23, 2021
CL 363474 added a 2012 builder, which is good, but it also took a major
step in sunsetting Windows 7 support by removing all 2008 builders from
trybots and for Go 1.18+. This will surely bitrot Windows 7 support and
force us to remove support for it, which isn't okay. Rather than line up
dominoes to force our hand on policy, such huge policy changes with
sweeping ramifications should be properly decided.

So, this commit keeps the 2008 builders in the running, alongside the
2012 ones.

Updates golang/go#47845.
Updates golang/go#49490.

Change-Id: I574f51ea22f638d2f9b09fcd00fdfc3097631771
Reviewed-on: https://go-review.googlesource.com/c/build/+/366656
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders NeedsFix new-builder release-blocker
Projects
Development

No branches or pull requests

3 participants