Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: "Jump to" dialog doesn't show on click or with hotkey #49556

Closed
mknyszek opened this issue Nov 12, 2021 · 5 comments
Closed

x/pkgsite: "Jump to" dialog doesn't show on click or with hotkey #49556

mknyszek opened this issue Nov 12, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@mknyszek
Copy link
Contributor

I accessed https://pkg.go.dev/golang.org/x/sys/unix and when I click on "Jump to" on the top left, nothing happens. Just to be completely unambiguous, I'm referring to the follow.

3xT5xN4NTwcRK4o (1)

Browser is Google Chrome Version 95.0.4638.69 (Official Build) (x86_64), OS is macOS 11.6.
@mknyszek mknyszek added this to the Unreleased milestone Nov 12, 2021
@jamalc
Copy link

jamalc commented Nov 12, 2021

Duplicate of #49455

@jamalc jamalc marked this as a duplicate of #49455 Nov 12, 2021
@jamalc jamalc closed this as completed Nov 12, 2021
@mknyszek
Copy link
Contributor Author

I saw that, but felt it was different, because it doesn't seem to capture that just clicking also doesn't work. To be clear, I'm not pushing back, leaving this as a duplicate is fine with me.

@jamalc
Copy link

jamalc commented Nov 12, 2021

That's fair, the other issue doesn't capture everything.

@jamalc jamalc reopened this Nov 12, 2021
@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 10, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/frontend Dec 10, 2021
@jamalc jamalc self-assigned this Dec 10, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/378096 mentions this issue: static/shared/modal: fix modal errors

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/378095 mentions this issue: third_party: update dialog polyfill

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 13, 2022
@jamalc
third_party: update dialog polyfill
3960c26 
For golang/go#49556
For golang/go#49455

Change-Id: I6404c1b6075ac24fd7e0c7706a71ff10fdb2c7f8
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/378095
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
4 participants
@mknyszek @hyangah @gopherbot @jamalc