Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/dashboard: permit specifying more than 1 builder owner #49596

Closed
dmitshur opened this issue Nov 15, 2021 · 3 comments
Closed

x/build/dashboard: permit specifying more than 1 builder owner #49596

dmitshur opened this issue Nov 15, 2021 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

The current HostConfig allows providing the email and GitHub username of the builder owner. In many cases, there are multiple people who operate and can help with builder problems, and that information tends to be lost in old issues, mailing lists, etc.

I think it'll be better if we support entering multiple owner entries, and display those at https://farmer.golang.org/builders.

CC @golang/release.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Nov 15, 2021
@dmitshur dmitshur added this to the Unreleased milestone Nov 15, 2021
@dmitshur dmitshur self-assigned this Nov 15, 2021
@dmitshur
Copy link
Contributor Author

dmitshur commented Nov 15, 2021

Currently aiming for the following new internal API:

-Owner       string // optional email of owner; empty means golang-dev
-OwnerGithub string // optional GitHub username of owner
+Owners []string // owner entries (can be "github.com/{username}" or email); empty means golang-dev

With a gh helper to make the "github.com/{username}" strings a bit shorter. For example:

Owners: []string{gh("@tuxillo")},

I considered making use of the x/build/internal/gophers package, but that might be one extra step for anyone less familiar with x/build to deal with, so leaving that for later (it's not clear that it'd be better).

@dmitshur
Copy link
Contributor Author

One way using x/build/internal/gophers helps is to be able to tell when a GitHub username and email belong to the same person, and avoid displaying/tracking both. It also helps reduce some duplication and chance of typos going unnoticed, and fewer places to update when contact info changes. So, I decided to just go ahead and use it now.

@gopherbot
Copy link

Change https://golang.org/cl/363983 mentions this issue: dashboard, cmd/coordinator: support multiple builder owners

@dmitshur dmitshur added this to In Progress in Go Release Team Nov 15, 2021
Go Release Team automation moved this from In Progress to Done Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants