Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: test timeouts on Windows without output #49682

Closed
bcmills opened this issue Nov 19, 2021 · 2 comments
Closed

runtime: test timeouts on Windows without output #49682

bcmills opened this issue Nov 19, 2021 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows release-blocker
Milestone

Comments

@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 19, 2021
@bcmills
Copy link
Member Author

bcmills commented Nov 19, 2021

The failure rate on these is fairly low — it's not clear to me whether it has actually increased during the 1.18 cycle, but it's also regular enough to indicate a problem that we should probably diagnose and fix. (Marking as release-blocker, but for Go 1.19 rather than 1.18.)

@bcmills bcmills added this to the Go1.19 milestone Nov 19, 2021
@aclements
Copy link
Member

aclements commented Mar 30, 2022

There haven't been any more failures since 2021-11-18T02:53:02-d8f7a64/windows-arm64-10.

First observed c893a85 13 Nov 00:50 2021 (2596 commits ago)
Last observed d8f7a64 18 Nov 02:53 2021 (2025 commits ago)
2.9% chance failure is still happening
0.18% failure probability (2 of 572 commits)

I skimmed through a few weeks worth of CLs following that commit and nothing jumped out at me as an obvious fix. CLs 366734 and 366735 might have fixed the issue for arm and arm64, but wouldn't explain the 386 and amd64 failures.

It's a bit unsatisfying, but I think we should close this. We can always reopen it if we see another failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows release-blocker
Projects
Status: Done
Development

No branches or pull requests

2 participants