Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: 'Packages' link mistakenly points to search box instead of standard package docs #49737

Open
eikenb opened this issue Nov 23, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@eikenb
Copy link

@eikenb eikenb commented Nov 23, 2021

New go.dev website's Packages link should go to the standard package docs (https://pkg.go.dev/std), not a search box. That is the new site has a regression in usability and should be reverted to the direct link.

@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2021
@rsc
Copy link
Contributor

@rsc rsc commented Nov 23, 2021

golang.org and go.dev were inconsistent in what the top bar 'Packages' link pointed to.
On golang.org it pointed to the standard library (like https://go.dev/pkg/?m=old).
On go.dev it pointed to pkg.go.dev.

We have to pick just one, and it seems far more useful to me
to go to a page that lets you find any package,
instead of a page that only shows some packages.

I believe the current behavior, of linking to pkg.go.dev, is working as intended.

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Nov 23, 2021

/cc @jamalc @julieqiu @dmitshur in case I am wrong about this.

Loading

@ALTree
Copy link
Member

@ALTree ALTree commented Nov 23, 2021

It makes sense for the Packages item on https://go.dev/ to go to the general pkgs search, but how do you discover https://pkg.go.dev/std now? Searching for "std" on https://pkg.go.dev/ doesn't work.

There has to be a way to find out what packages Go actually ships with. The quickest way appears to be: click on Docs to reach https://go.dev/doc/, then scroll down to

Package Documentation

The documentation for the Go standard library.

which then links to https://pkg.go.dev/std, under the cryptic "Package Documentation" title (what package?) But that's like two thirds down, in a page with other 45 links, all equally prominent.

IMO there should be a link to https://pkg.go.dev/std prominent on https://pkg.go.dev/. So I would see something like "Standard library documentation" that jumps to https://pkg.go.dev/std, or I'd use the search bar if instead I wanted to look for 3rd party packages.

Loading

@ALTree ALTree added the pkgsite label Nov 23, 2021
@seankhliao
Copy link
Contributor

@seankhliao seankhliao commented Nov 23, 2021

I believe that part is #40785

Loading

@ALTree
Copy link
Member

@ALTree ALTree commented Nov 23, 2021

Ah, that's right. I forgot about that one. It certainly got more relevant now that the migration to go.dev is in progress.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2021

Change https://golang.org/cl/366577 mentions this issue: _content: adjust footer

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Nov 24, 2021

I sent a CL to put "Standard Library" in the footer menu under "Packages".

Loading

@rsc rsc self-assigned this Nov 24, 2021
@ALTree ALTree mentioned this issue Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants