Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: anchor links don't seem to work properly anymore #49754

Open
mvdan opened this issue Nov 23, 2021 · 3 comments
Open

x/website: anchor links don't seem to work properly anymore #49754

mvdan opened this issue Nov 23, 2021 · 3 comments
Assignees
Labels
Milestone

Comments

@mvdan
Copy link
Member

@mvdan mvdan commented Nov 23, 2021

I think this is a regression from when golang.org was replaced by go.dev in the past week or so.

If I go to https://go.dev/ref/spec#Order_of_evaluation on either Firefox 94.0.2 or Chrome 96.0.4664.45, the anchor link doesn't seem to be working properly, as I don't see the heading I linked to unless I scroll back up.

I imagine this might be related to the banners at the top, as they are what is blocking the view.

image

Here is roughly what I expected to see:

image

cc @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2021
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Nov 23, 2021

Thanks for the report. This issue is reproducible for me too.

CC @jamalc, @rsc.

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Nov 24, 2021

Thanks. The problem is the floating header. It seems OK to me for now to just unfloat the header. I will send a CL for that.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2021

Change https://golang.org/cl/366974 mentions this issue: _content/css: let the go.dev header float

Loading

@rsc rsc self-assigned this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants