Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: download button only knows about macOS and Windows #49765

Open
cespare opened this issue Nov 23, 2021 · 6 comments
Open

x/website: download button only knows about macOS and Windows #49765

cespare opened this issue Nov 23, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@cespare
Copy link
Contributor

@cespare cespare commented Nov 23, 2021

What is the URL of the page with the issue?

https://go.dev/, for example

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36

Screenshot

screen_20211123133124

What did you do?

Clicked the download button on the front page using a Linux machine

What did you expect to see?

A Linux tarball

What did you see instead?

A Windows MSI

Reported on Twitter by @dominikh.

@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2021
@mvdan
Copy link
Member

@mvdan mvdan commented Nov 23, 2021

I can reproduce. How was the new website tested against the old site for regressions? There's also #49754, for example.

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Nov 24, 2021

This is not a regression.
This part of https://go.dev/ has been like this for a very long time.
People are just paying more attention to it now.
Will fix.

Loading

@mvdan
Copy link
Member

@mvdan mvdan commented Nov 24, 2021

I meant regression as in: new users navigating to golang.org on Linux no longer get a Linux download button by default :)

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Nov 24, 2021

Indeed. It's much worse that go.dev has always been like that!

Loading

@rsc rsc self-assigned this Nov 24, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2021

Change https://golang.org/cl/366976 mentions this issue: _content: remove go.dev download button "smarts"

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2021

Change https://golang.org/cl/366975 mentions this issue: _content: fix download button on non-Mac, non-Windows browsers

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants