Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: clicking "share" on the playground reloads the entire page #49766

Open
mvdan opened this issue Nov 23, 2021 · 3 comments
Open

x/website: clicking "share" on the playground reloads the entire page #49766

mvdan opened this issue Nov 23, 2021 · 3 comments

Comments

@mvdan
Copy link
Member

@mvdan mvdan commented Nov 23, 2021

I'm fairly sure this did not happen with the old play.golang.org - it would simply update the URL in the browser bar and in the "share" textbox, but it wouldn't reload the entire page.

I don't lose any code with the reload, but it's still slightly distracting. Particularly since the code takes nearly a second for me to fully render again, so the site becomes unusable while it's doing the presumably unnecessary reload.

@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2021
@mvdan
Copy link
Member Author

@mvdan mvdan commented Nov 23, 2021

Switching between the built-in examples sort of has the opposite problem. The code does change without a full reload, but the URL doesn't change, so it remains on whatever URL I got from my last click of "share".

Loading

@nishanths
Copy link

@nishanths nishanths commented Nov 24, 2021

Similar: #49742.

But that issue doesn't mention the problem described in the first comment here.

Loading

@zikaeroh
Copy link
Contributor

@zikaeroh zikaeroh commented Nov 24, 2021

Yes, apparently I didn't notice that the whole page actually reloaded and assumed it was some sneaky history modification in my issue. It definitely reloads everything and removes the output.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants