Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: some important pages seem to not be linked to #49768

Open
mvdan opened this issue Nov 23, 2021 · 5 comments
Open

x/website: some important pages seem to not be linked to #49768

mvdan opened this issue Nov 23, 2021 · 5 comments
Assignees
Milestone

Comments

@mvdan
Copy link
Member

@mvdan mvdan commented Nov 23, 2021

For example, https://go.dev/doc/contribute is an invaluable resource for contributing to Go, but I can't find it under https://go.dev/doc/.

I imagine other pages also fell off the radar given the website redesign, but I'm not sure how to check.

@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2021
@rsc
Copy link
Contributor

@rsc rsc commented Nov 24, 2021

There shouldn't be very many unlinked pages, since all the content on golang.org moved over verbatim except for the front page. Looking at the old front page, the old header linked to /project and /help/, which may not have links anymore. I've put both of them into the footer in CL 366577. Thanks!

Loading

@rsc rsc self-assigned this Nov 24, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2021

Change https://golang.org/cl/366577 mentions this issue: _content: adjust footer

Loading

@fzipp
Copy link
Contributor

@fzipp fzipp commented Nov 24, 2021

The "Contribution Guide" is reachable via the website, but it's deeply buried:

"Docs" -> "Installing Go" -> "Installing Go from source" -> "(Optional) Switch to the master branch" -> "contribute your changes"

I think it was the same on the old website, so it's not a regression.

Loading

@mvdan
Copy link
Member Author

@mvdan mvdan commented Nov 24, 2021

Ah, so now "About" will point to https://go.dev/project, which does have a direct link to the contribution guide. That seems like a big improvement, thanks!

I think it was the same on the old website, so it's not a regression.

That's entirely fair - I don't recall exactly the layout of the old site, and I don't have a way to check easily now that the site redirects.

Loading

@JeremyLoy
Copy link

@JeremyLoy JeremyLoy commented Nov 26, 2021

There also doesn’t seem to be a link to the standard library either

IIRC clicking packages in the hamburger menu used to bring you to this page

now, it brings you to the pkg.go.dev search

the old page was at /pkg but the new page is at /std so this actually might just be a case of a bad redirect

Loading

@ALTree ALTree mentioned this issue Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants