Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: include Go version information in gopls version output #49783

Open
findleyr opened this issue Nov 24, 2021 · 4 comments
Open

x/tools/gopls: include Go version information in gopls version output #49783

findleyr opened this issue Nov 24, 2021 · 4 comments

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Nov 24, 2021

As discussed in CL 366736, gopls version lacks information about the Go version used to build gopls (and possibly the Go version found by exec.LookPath). We should add it, to facilitate bug reporting.

CC @hyangah

@hyangah
Copy link
Contributor

@hyangah hyangah commented Nov 24, 2021

In case gopls version output format changes significantly, we need to adjust vscode-go's gopls version parsing code and release vscode-go first.

Loading

@findleyr
Copy link
Contributor Author

@findleyr findleyr commented Nov 24, 2021

In case gopls version output format changes significantly, we need to adjust vscode-go's gopls version parsing code and release vscode-go first.

If this is being parsed, maybe we should just add a -json flag? WDYT?

Loading

@hyangah
Copy link
Contributor

@hyangah hyangah commented Nov 24, 2021

I think vscode-go should stop parsing gopls version result but use go version -m as part of managing versions of all tools. :-)

And I guess you may want to include the go version to the verbose output (gopls -v version) only.

Loading

@findleyr
Copy link
Contributor Author

@findleyr findleyr commented Nov 24, 2021

I think vscode-go should stop parsing gopls version result but use go version -m as part of managing versions of all tools. :-)

Oh yeah, that sounds correct.

And I guess you may want to include the go version to the verbose output (gopls -v version) only.

Yes, I think this should be -v only. We'll ask people to invoke gopls -v version in the issue template.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants