Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestClientWriteShutdown failures on darwin-arm64-11_0-toothrot #49860

Open
bcmills opened this issue Nov 29, 2021 · 3 comments
Open

net/http: TestClientWriteShutdown failures on darwin-arm64-11_0-toothrot #49860

bcmills opened this issue Nov 29, 2021 · 3 comments

Comments

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 29, 2021

This looks to me like a deadlock, but (due to the use of an unnecessary and arbitrary timeout) the test is currently not producing useful goroutine dumps to diagnose it.

We need to fix the test before we can fix the underlying deadlock.

@bcmills bcmills removed this from the Backlog milestone Nov 29, 2021
@bcmills bcmills added this to the Go1.19 milestone Nov 29, 2021
@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 29, 2021

Marking as release-blocker for Go 1.19, rather than 1.18, because it appears to affect a single platform and it isn't obvious to me that we well have a useful goroutine dump to diagnose it before the 1.18 release.

(I suspect that we will want to backport the fix once it is identified.)

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 29, 2021

Change https://golang.org/cl/367615 mentions this issue: net/http: eliminate arbitrary timeout in TestClientWriteShutdown

gopherbot pushed a commit that referenced this issue Nov 30, 2021
This test occasionally hangs on the darwin-arm64-11_0-toothrot
builder. When it does, it fails with the unhelpful error message
"timeout" instead of a useful goroutine dump.

This change eliminates the use of an arbitrary timeout channel, so
that if (and probably when) the test hangs again we will get more
useful logs to diagnose the root cause.

For #49860

Change-Id: I23f6f1c81209f0b2dbe565e1dfb26b1b2eff0187
Reviewed-on: https://go-review.googlesource.com/c/go/+/367615
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants