Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/release: confirm selection of darwin/arm64 releaselet macOS version for next minor release #49889

Closed
dmitshur opened this issue Nov 30, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Nov 30, 2021

We should confirm which macOS version will be used for building darwin/arm64 binaries for the next Go 1.17.4 (and 1.16.11) minor releases, and whether any changes need to be done to avoid breaking compatibility with either macOS 11 or 12.

See https://go-review.googlesource.com/c/build/+/365736/3/cmd/release/release.go#222 for details.

CC @golang/release, @cherrymui.

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 30, 2021
@dmitshur dmitshur added this to the Go1.17.4 milestone Nov 30, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 30, 2021
@dmitshur dmitshur self-assigned this Dec 1, 2021
@dmitshur
Copy link
Contributor Author

dmitshur commented Dec 1, 2021

So far, I've built a darwin-arm64 tarball using the macOS 12 builder. I plan to try it out on macOS 11 to see if I'm able to find a reproducible issue with it.

@toothrot and I talked this over, and confirmed the motivation in CL 365736 to make the change for 1.17 and 1.16 releases was, at the time, out of necessity because the two macOS 11 builders were being replaced with macOS 12. However we've since gone back to having one of each. (Which in itself is not ideal and we will try to improve it over time.)

For the upcoming minor release, we'll revert the change and use macOS 11 builder as was used in previous releases. Go 1.18 Beta 1 can still use macOS 12 if testing above doesn't find clear evidence of a problem (I'll comment on #40561 later on).

Will send a CL to update x/cmd/build/release to resolve this. CC @mknyszek

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 1, 2021
@gopherbot
Copy link

Change https://golang.org/cl/368394 mentions this issue: cmd/release: revert to macOS 11 builder for 1.17, 1.16 minor releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants