Skip to content

x/website: running code in go.dev/tour doesn't work #49936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leitzler opened this issue Dec 2, 2021 · 6 comments
Closed

x/website: running code in go.dev/tour doesn't work #49936

leitzler opened this issue Dec 2, 2021 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@leitzler
Copy link
Contributor

leitzler commented Dec 2, 2021

What did you do?

Opened up https://go.dev/tour/welcome/1 and clicked the "Run" button in the embedded playground.

Browser: Chrome Version 96.0.4664.55 (Official Build) (x86_64)

What did you expect to see?

Output populated.

What did you see instead?

Error communicating with remote server in the output.

The POST request initated when pressing "Run" goes to https://go.dev/_/compile?backend=undefined and it throws an 500 Internal Server Error.

Looks like an side effect from CL 366056 where support for backends was added to the ordinary playground, while the tour doesn't have that option? If I remove undefined from the call it works as expected.

//cc @rsc
@gopherbot gopherbot added this to the Unreleased milestone Dec 2, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/368914 mentions this issue: _content/js: fix tour playground

@fzipp
Copy link
Contributor

fzipp commented Dec 3, 2021

The "Try Go" code box on the go.dev front page has the same problem.

@mknyszek
Copy link
Contributor

mknyszek commented Dec 3, 2021

CC @dmitshur @rsc

@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 3, 2021
@mknyszek
Copy link
Contributor

mknyszek commented Dec 3, 2021

Ah, sorry. @jba already got to it. Please ignore, Dmitri, Russ.

@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 3, 2021
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 3, 2021
@jba
Copy link
Contributor

jba commented Dec 3, 2021

For the record, it was @jamalc.

@mknyszek
Copy link
Contributor

mknyszek commented Dec 3, 2021

Ah! My bad. I had only looked at the reviewer and nothing else on that page. Thanks.

@seankhliao seankhliao mentioned this issue Dec 6, 2021
Closed
@fzipp fzipp mentioned this issue Dec 8, 2021
Closed
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
_content/js: fix tour playground
8ff8b8b 
Fixed a malformed request URL when options.backend is undefined.

Fixes golang/go#49936
Fixes golang/tour#1281

Change-Id: I9c2c29d2d67e3bffe0d490517f6a9168a6d4dc46
Reviewed-on: https://go-review.googlesource.com/c/website/+/368914
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@fzipp @mknyszek @leitzler @gopherbot @jba