Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: failures in TestVectoredHandlerDontCrashOnLibrary on windows-amd64-longtest #49959

Open
bcmills opened this issue Dec 3, 2021 · 4 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Dec 3, 2021

--- FAIL: TestVectoredHandlerDontCrashOnLibrary (6.69s)
    signal_windows_test.go:58: expected output "exceptionCount: 1\ncontinueCount: 1\n", got ""
FAIL
FAIL	runtime	215.975s

greplogs --dashboard -md -l -e 'FAIL: TestVectoredHandlerDontCrashOnLibrary'

2021-11-24T20:56:40-9e7600d/windows-amd64-longtest
2021-11-12T23:26:33-3a4b950/windows-amd64-longtest
2021-11-09T20:10:50-5430203/windows-amd64-longtest

This appears to be a regression during the Go 1.18 cycle; it may be related in some way to #49681.

(CC @bufflig @alexbrainman)

@bufflig
Copy link
Contributor

@bufflig bufflig commented Dec 3, 2021

Yea, looks related. And as with that one, probably a pain to reproduce, but I'll try.

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Dec 15, 2021

Hasn't occurred since 2021-11-24. I also tried to reproduce on gomote but couldn't reproduce.

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Dec 15, 2021

The interesting part is that the binary runs successfully with no error, just didn't print anything. This may be different from #49681.

Maybe we need fflush or something to flush the output? I would think we don't need that as it exits normally. But I'm not sure I know enough about C buffered I/O on Windows.

@aclements
Copy link
Member

@aclements aclements commented Jan 4, 2022

This hasn't happened again. Unfortunately, it was rare enough that that doesn't tell us much:

$ greplogs --dashboard -l -e 'FAIL: TestVectoredHandlerDontCrashOnLibrary' -since 2021-01-01 | findflakes -paths
First observed 5430203 09 Nov 20:10 2021 (2604 commits ago)
Last observed  9e7600d 24 Nov 20:56 2021 (658 commits ago)
51% chance failure is still happening
0.10% failure probability (3 of 1947 commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants