Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/benchmarks/cmd/bent: TestBent failing on Android builders since CL 320970 #49964

Closed
bcmills opened this issue Dec 3, 2021 · 2 comments
Closed

x/benchmarks/cmd/bent: TestBent failing on Android builders since CL 320970 #49964

bcmills opened this issue Dec 3, 2021 · 2 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 3, 2021 •
edited
Loading 

go: downloading github.com/BurntSushi/toml v0.3.1
bent.go:109:12: pattern configs/*: no matching files found

--- FAIL: TestBent (3.06s)
    bent_test.go:53: exit status 1
FAIL
exitcode=1
FAIL	golang.org/x/benchmarks/cmd/bent	36.184s

This is because the Android exec wrapper that runs the test only copies in that package's testdata directory and those of its parent directories. Since the configs directory is neither, the go build subprocess fails to rebuild cmd/bent.

I can think of three ways to address this:

  1. Add appropriate skips to the test (so that we don't try to execute it on Android).
  2. Adjust x/build/dashboard/builders.go to skip this repo on the Android builders.
  3. Adjust the way the files are bundled (and perhaps also adjust the way the test executes cmd/bent) so that it can run successfully on Android.

(attn: @dr2chase, @prattmic, @mknyszek)
@bcmills bcmills changed the title x/benchmarks/cmd/bent: TestBent failing on Android builders nince x/benchmarks/cmd/bent: TestBent failing on Android builders since CL 320970 Dec 3, 2021
@bcmills bcmills added mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 3, 2021
@bcmills bcmills added this to the Go1.18 milestone Dec 3, 2021
@dr2chase
Copy link
Contributor

dr2chase commented Dec 3, 2021

Can I create a temporary directory and write files in it on Android builders?

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/369159 mentions this issue: cmd/bent: modify test to avoid rebuilding bent

@golang golang locked and limited conversation to collaborators Dec 6, 2022
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this issue Apr 22, 2024
@dr2chase
cmd/bent: modify test to avoid rebuilding bent
fa2991d 
this allows the test to run on more platforms, and also to
run more quickly.

Fixes golang/go#49964.

Change-Id: I8b0661af6f00d40e1580652a6594312544b3e0df
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this issue Apr 22, 2024
@dr2chase
cmd/bent: modify test to avoid rebuilding bent
9c707a3 
this allows the test to run on more platforms, and also to
run more quickly.

Fixes golang/go#49964.

Change-Id: I8b0661af6f00d40e1580652a6594312544b3e0df
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@dr2chase @bcmills @gopherbot