Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: TestLabelSystemstack failures with "no samples in expected functions" #50050

Closed
bcmills opened this issue Dec 8, 2021 · 3 comments
Assignees
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Dec 8, 2021

--- FAIL: TestLabelSystemstack (7.24s)
    pprof_test.go:526: total 36 CPU profile samples collected:
        1: 0x410e23 (runtime.(*mspan).refillAllocCache:153) 0x410ff1 (runtime.(*mspan).nextFreeIndex:211) 0x40b215 (runtime.(*mcache).nextFree:879) 0x40b6ba (runtime.mallocgc:1060) 0x409565 (runtime.convT32:372) 0x547ae8 (runtime/pprof.labelHog:1476) 0x54773b (runtime/pprof.TestLabelSystemstack.func1.1.1:1437) labels: map[key:[value]]
[…]
    pprof_test.go:597: runtime.systemstack;key=value: 0
    pprof_test.go:600: no samples in expected functions
    pprof_test.go:611: runtime.systemstack;key=value has 0 samples out of 0, want at least 1, ideally 0
    pprof_test.go:462: retrying with 3.2s duration
    pprof_test.go:526: total 1279 CPU profile samples collected:
        8: 0x46c11f (sync.(*Pool).Put:103) 0x4b4222 (fmt.(*pp).free:161) 0x4b449d (fmt.Fprintf:206) 0x547b3c (runtime/pprof.labelHog:1476) 0x54773b (runtime/pprof.TestLabelSystemstack.func1.1.1:1437) labels: map[key:[value]]
        
        1: 0x4610f0 (sync.runtime_procUnpin:6265) 0x46c175 (sync.(*Pool).Put:110) 0x4b4222 (fmt.(*pp).free:161) 0x4b449d (fmt.Fprintf:206) 0x547b3c (runtime/pprof.labelHog:1476) 0x54773b (runtime/pprof.TestLabelSystemstack.func1.1.1:1437) labels: map[key:[value]]
[…]
    pprof_test.go:597: runtime.systemstack;key=value: 0
    pprof_test.go:600: no samples in expected functions
    pprof_test.go:611: runtime.systemstack;key=value has 0 samples out of 0, want at least 1, ideally 0

greplogs --dashboard -md -l -e 'FAIL: TestLabelSystemstack .*\n(?: .+\n)* .*no samples in expected functions' --since=2021-12-07

2021-12-08T15:30:52-9fe77de/windows-386-2008

(attn @felixge @prattmic)

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 8, 2021
@bcmills bcmills added this to the Go1.18 milestone Dec 8, 2021
@bcmills
Copy link
Member Author

bcmills commented Dec 8, 2021

(Release blocker for Go 1.18 because this test is new as of 1.18.)

@prattmic
Copy link
Member

prattmic commented Dec 8, 2021

I think this is just a case of getting unlucky and not getting the sample we want in time. fmt.Fprintf way not be the best sink here, I'll look around for a better one.

@gopherbot
Copy link

Change https://golang.org/cl/370375 mentions this issue: runtime/pprof: increase systemstack calls in TestLabelSystemstack

@prattmic prattmic self-assigned this Feb 17, 2022
@prattmic prattmic self-assigned this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants