Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Missing links in burger menu #50070

Closed
Deleplace opened this issue Dec 9, 2021 · 2 comments
Closed

x/pkgsite: Missing links in burger menu #50070

Deleplace opened this issue Dec 9, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite

Comments

@Deleplace
Copy link
Contributor

What is the URL of the page with the issue?

https://pkg.go.dev/

(same issues for all packages pages, e.g. https://pkg.go.dev/io , https://pkg.go.dev/search?q=io.writer , etc.)

Screenshot

image

What did you do?

I adjusted my browser window to a smaller viewport width, which has the effect of hiding the topbar links, and replace them with a burger menu that opens a vertical list of links.

I clicked the burger menu icon.

What did you expect to see?

The 6 exact same links as in the full-width topbar:
image

and as the main page go.dev's burger menu:

image

What did you see instead?

Only 4 links instead of 6.

These 2 links are missing:

  • Docs
  • Play
@gopherbot gopherbot added this to the pkgsite/unplanned milestone Dec 9, 2021
@jamalc jamalc added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 10, 2021
@jamalc jamalc self-assigned this Dec 10, 2021
amankapoor added a commit to amankapoor/pkgsite that referenced this issue Dec 28, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/377397 mentions this issue: static/shared/header: add missing links to mobile nav menu

@Deleplace
Copy link
Contributor Author

Thank you!

@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Development

No branches or pull requests

4 participants