Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: race detector SIGABRT or SIGSEGV on macOS Monterey [1.16 backport] #50072

Closed
gopherbot opened this issue Dec 9, 2021 · 3 comments
Closed

runtime: race detector SIGABRT or SIGSEGV on macOS Monterey [1.16 backport] #50072

gopherbot opened this issue Dec 9, 2021 · 3 comments
Labels
CherryPickApproved
Milestone
Go1.16.13

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 9, 2021

@cherrymui requested issue #49138 to be considered for backport to the next 1.16 minor release.

@gopherbot please open a backport of this for Go 1.16 and 1.17 releases. Thanks.
@gopherbot gopherbot added the CherryPickCandidate label Dec 9, 2021
@gopherbot gopherbot mentioned this issue Dec 9, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.13 milestone Dec 9, 2021
@cherrymui
Copy link
Member

@cherrymui cherrymui commented Dec 9, 2021

(See #50073 (comment) for discussion)

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Dec 9, 2021

Change https://golang.org/cl/370698 mentions this issue: [release-branch.go1.16] runtime/race: rebuild darwin syso to work around macOS 12 malloc reserved address

@cherrymui cherrymui added CherryPickApproved and removed CherryPickCandidate labels Dec 15, 2021
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Dec 22, 2021

Closed by merging 281860c to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Dec 22, 2021
@cherrymui @dmitshur
[release-branch.go1.16] runtime/race: rebuild darwin syso to work aro…
281860c 
…und macOS 12 malloc reserved address

On macOS 12 a new malloc implementation (nano) is used by default,
and apparently it reserves address range
0x600000000000-0x600020000000, which conflicts with the address
range that TSAN uses for Go. Work around the issue by changing the
address range slightly.

The actual change is made on LLVM at https://reviews.llvm.org/D114825 .
This CL includes syso's built with the patch applied.

The syso in 1.16 was identical to the syso before the equivalent fix
on the main branch, so the back-ported syso is identical to the fixed
syso on the main branch.

Fixes #50072.
Updates #49138.

Change-Id: I7b367d6e042b0db39a691c71601c98e4f8728a70
Reviewed-on: https://go-review.googlesource.com/c/go/+/367916
Trust: Cherry Mui <cherryyz@google.com>
Reviewed-by: Austin Clements <austin@google.com>
(cherry picked from commit 5f65520)
Reviewed-on: https://go-review.googlesource.com/c/go/+/370698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved
Projects
None yet
Milestone
Go1.16.13
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui