Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/benchmarks/sweet/benchmarks/internal/pool: failures with "expected error from bad worker" #50096

Closed
bcmills opened this issue Dec 10, 2021 · 2 comments
Labels
NeedsFix okay-after-beta1 release-blocker
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Dec 10, 2021

greplogs --dashboard -md -l -e 'FAIL: TestPoolError .*\n .*expected error from bad worker'

2021-12-10T19:26:50-df0ca34-766f89b/linux-amd64-race
2021-12-02T18:28:30-2890d99-c5c1955/freebsd-amd64-13_0

This test was added in CL 368195 (CC @mknyszek, @dr2chase, @prattmic).

It looks like this is reporting a real bug in the internal/pool package, probably here:
https://cs.opensource.google/go/x/benchmarks/+/master:sweet/benchmarks/internal/pool/pool.go;l=126-135;drc=940a5193d97ee097a93c26c7123d691304e5e3f4

This sort of completion-vs-error race (and the associated cancellation pattern) is pretty much exactly the one that the errgroup package was designed to address. I would recommend using that here.

@gopherbot gopherbot added this to the Unreleased milestone Dec 10, 2021
@bcmills bcmills added the NeedsFix label Dec 10, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 10, 2021

Change https://golang.org/cl/370974 mentions this issue: sweet/benchmarks/internal/pool: use errgroup to manage errors and cancellation

@bcmills bcmills added okay-after-beta1 release-blocker labels Dec 10, 2021
@bcmills bcmills removed this from the Unreleased milestone Dec 10, 2021
@bcmills bcmills added this to the Go1.18 milestone Dec 10, 2021
@bcmills
Copy link
Member Author

@bcmills bcmills commented Dec 10, 2021

(This is a release-blocker via #11811, but the fix is straightforward so I've mailed it out.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix okay-after-beta1 release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants