Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add go:embed support #50262

Open
hamidfzm opened this issue Dec 10, 2021 · 1 comment
Open

x/tools/gopls: add go:embed support #50262

hamidfzm opened this issue Dec 10, 2021 · 1 comment

Comments

@hamidfzm
Copy link

@hamidfzm hamidfzm commented Dec 10, 2021

Is your feature request related to a problem? Please describe.
Go embed feature introduced in version 1.16. Currently, go-vscode treats text like //go:embed app as a simple comment.

Describe the solution you'd like
Provide text highlighting or navigation by CTRL+Clicking on these comments

Describe alternatives you've considered
Goland provides this feature in its recent versions:
Screenshot from 2021-12-10 18-21-42

Additional context
VS code view
Screenshot from 2021-12-10 18-25-51

It would be really nice if we have this feature in my favorite code editor.

@findleyr
Copy link
Contributor

@findleyr findleyr commented Dec 19, 2021

This could be implemented with a code action+associated command that invokes window/showDocument. It could also be implemented with jump-to-definition+hover. I am not sure which is best, but this seems to belong in the gopls issue tracker.

@findleyr findleyr transferred this issue from golang/vscode-go Dec 19, 2021
@findleyr findleyr changed the title Add go:embed support x/tools/gopls: add go:embed support Dec 19, 2021
@gopherbot gopherbot added this to the Unreleased milestone Dec 19, 2021
@findleyr findleyr removed this from the Unreleased milestone Dec 19, 2021
@findleyr findleyr added this to the gopls/unplanned milestone Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants