Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: does not set section type of .init_array correctly [1.17 backport] #50297

Closed
gopherbot opened this issue Dec 21, 2021 · 3 comments
Closed
Labels
CherryPickApproved Used during the release process for point releases
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Dec 21, 2021

@ianlancetaylor requested issue #50295 to be considered for backport to the next 1.17 minor release.

@gopherbot Please open backport issues

We need to fix this for -buildmode=c-archive to work with new versions of lld.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 21, 2021
@gopherbot gopherbot added this to the Go1.17.7 milestone Dec 21, 2021
@gopherbot
Copy link
Author

gopherbot commented Dec 22, 2021

Change https://golang.org/cl/374194 mentions this issue: [release-branch.go1.17] cmd/link: use SHT_INIT_ARRAY for .init_array section

@cagedmantis
Copy link
Contributor

cagedmantis commented Jan 5, 2022

This is a serious issue without a workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Jan 5, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 5, 2022
@gopherbot
Copy link
Author

gopherbot commented Jan 5, 2022

Closed by merging ab70d7c to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Jan 5, 2022
…section

For #50295
Fixes #50297

Change-Id: If55ebcd5f2af724da7c9c744458a56d21a7ddde7
Reviewed-on: https://go-review.googlesource.com/c/go/+/373734
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit cfb0cc3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/374194
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Development

No branches or pull requests

2 participants