Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: add asmlint #5036

Closed
rsc opened this issue Mar 12, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@rsc
Copy link
Contributor

commented Mar 12, 2013

One of the things changing in Go 1.1 is the size of int, necessitating updates of all
the assembly functions that have unsized ints as arguments or results. 

code.google.com/p/rsc/cmd/asmlint is the tool I wrote to read Go forward declaration and
scan assembly listings for incorrect offsets or type mismatches. This is what I used to
update the Go tree when we made the change.

Now that cmd/vet knows about build.Packages, it should be straightforward to drop this
code into a new vet module and have it emit errors. The asmlint command also has a
"fix everything" mode, but we could drop or disable that for integration with
vet. I think it suffices to report the errors.

https://code.google.com/p/rsc/source/browse/cmd/asmlint/main.go
@rsc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2013

Comment 1:

This issue was closed by revision b5cfbda.

Status changed to Fixed.

@rsc rsc added fixed labels Mar 22, 2013

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015

@rsc rsc removed the go1.1 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.