Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: link to custom links is broken. #50387

Closed
lostluck opened this issue Dec 29, 2021 · 3 comments
Closed

x/pkgsite: link to custom links is broken. #50387

lostluck opened this issue Dec 29, 2021 · 3 comments
Labels
FrozenDueToAge pkgsite
Milestone
pkgsite/unplanned

Comments

@lostluck
Copy link

lostluck commented Dec 29, 2021 •
edited
Loading

What is the URL of the page with the issue?

https://pkg.go.dev/about

What is your user agent? (N/A)

Mozilla/5.0 (X11; CrOS x86_64 14268.51.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.77 Safari/537.36

Screenshot

N/A

What did you do?

Click on the link to "this issue" in the Adding links section. https://pkg.go.dev/about#adding-links

What did you expect to see?

#42968

What did you see instead?

https://pkg.go.dev/issue/42968 (currently a 404)
@gopherbot gopherbot added this to the pkgsite/unplanned milestone Dec 29, 2021
@lostluck
Copy link
Author

I'm happy to put in the quick fix to fix the link, and am spining up my contribution set up.

@lostluck
Copy link
Author

https://go-review.googlesource.com/c/pkgsite/+/374854

@jamalc
Copy link

jamalc commented Jan 10, 2022

Fixed in CL 374854

@jamalc jamalc closed this as completed Jan 10, 2022
@golang golang locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@gopherbot @lostluck @jamalc