Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestIssue16471 failures with "testgo succeeded unexpectedly" #50471

Closed
bcmills opened this issue Jan 6, 2022 · 5 comments
Closed

cmd/go: TestIssue16471 failures with "testgo succeeded unexpectedly" #50471

bcmills opened this issue Jan 6, 2022 · 5 comments
Assignees
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Jan 6, 2022

#!watchflakes
post <- pkg == "cmd/go" && (test == "TestIssue16471" || test == "TestScript/get_issue16471")
--- FAIL: TestIssue16471 (11.10s)
    go_test.go:936: git standard error:
    go_test.go:936: Cloning into 'go-get-issue-10952'...
        
    go_test.go:937: running testgo [get -u rsc.io/go-get-issue-10952]
    go_test.go:937: testgo succeeded unexpectedly
FAIL
FAIL	cmd/go	134.322s

greplogs --dashboard -md -l -e '(?ms)FAIL: TestIssue16471.*testgo succeeded unexpectedly'

2022-01-06T00:26:47-b5bfaf4/linux-386-longtest
2021-11-16T15:59:43-79d0013/linux-386-longtest
2021-08-27T05:13:44-2c60a99/linux-386-longtest
2021-08-27T00:36:45-e7eee5e/linux-386-longtest
2021-06-29T02:34:20-e2e05af/linux-amd64-longtest

@bcmills
Copy link
Member Author

bcmills commented Jan 6, 2022

This is the regression test for #16471 / #10952.

@bcmills bcmills self-assigned this Jan 6, 2022
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 6, 2022
@bcmills bcmills added this to the Go1.18 milestone Jan 6, 2022
@bcmills bcmills added the GoCommand cmd/go label Jan 6, 2022
@bcmills
Copy link
Member Author

bcmills commented Jan 7, 2022

About half of the failures in the logs seem to coincide with rsc.io server outages that cause other tests to fail.

Otherwise, in order to make progress debugging we will need more output from go get -u. I will port the test to a script and add the -x flag to get more detail about what the spuriously-succeeding command is doing.

@bcmills bcmills modified the milestones: Go1.18, Backlog Jan 7, 2022
@gopherbot
Copy link

Change https://golang.org/cl/376359 mentions this issue: cmd/go: port TestIssue16471 to a script test and add verbose logging

gopherbot pushed a commit that referenced this issue Jul 12, 2022
For #50471

Change-Id: I082c1f96113a3228f2ef423a04eaa9fbaa6c7522
Reviewed-on: https://go-review.googlesource.com/c/go/+/376359
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
For golang#50471

Change-Id: I082c1f96113a3228f2ef423a04eaa9fbaa6c7522
Reviewed-on: https://go-review.googlesource.com/c/go/+/376359
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == "TestIssue16471" && `testgo succeeded unexpectedly`
2023-01-06 17:52 linux-386-longtest go@476384ec cmd/go.TestIssue16471 (log)
go test proxy running at GOPROXY=http://127.0.0.1:34321/mod
--- FAIL: TestIssue16471 (10.66s)
    go_test.go:936: git standard error:
    go_test.go:936: Cloning into 'go-get-issue-10952'...

    go_test.go:937: running testgo [get -u rsc.io/go-get-issue-10952]
    go_test.go:937: testgo succeeded unexpectedly

watchflakes

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 19, 2023
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Status: Done
Development

No branches or pull requests

2 participants