x/pkgsite: CreateOrder example on go.dev/doc/database/execute-transactions page doesn't compile

[imballinst]

What is the URL of the page with the issue?

https://go.dev/doc/database/execute-transactions

What is your user agent?

Firefox 94.0 (64-bit)

Screenshot

The fail function (below the marked comment), expects 2 return values. However, the function only returns fmt.Errorf(...).

What did you do?

I copy-pasted the code to my IDE (VS Code) and got an error (the return line was marked with a red line).

What did you expect to see?

There should be no error in the copy-pasted function. It should return, maybe, 0, fmt.Errorf(...)?

What did you see instead?

Error during compilation.

./main.go:229:3: not enough arguments to return
	have (error)
	want (int64, error)

I'm new to Go, so please let me know if I did something wrong instead. Thanks!

[odeke-em]

Thank you for filing this bug @imballinst and welcome to the Go project! Thank you @seankhliao for the triage. Happy New Year y'all!

@willpoint is going to send a CL shortly to fix this.

[gopherbot]

Change https://golang.org/cl/376974 mentions this issue: _content/doc: ensure database example code compiles

[dharmit]

@odeke-em well the PR looks good (or could've used orderID instead of 0 - no big deal). Could someone with enough rights help merge it so that the example isn't broken any more?